static getters in es6 classes is bad-sim-text

phetsims / number-line-integers

"Number Line: Integers" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

0 stars 4 forks source link

static getters in es6 classes is bad-sim-text #37

Closed zepumph closed 5 years ago

zepumph commented 5 years ago

Since some work was done on https://github.com/phetsims/chipper/issues/791 a few weeks ago, the bad-sim-text lint rule has not been working right. As a result, it didn't error on static getters added in BankSceneModel.js. I added // eslint-disable-line bad-sim-text, but this isn't good enough. We don't support them because Babel doesn't transpile them appropriately. see https://github.com/phetsims/tasks/issues/983.

jbphet commented 5 years ago

Thanks @zepumph - good to know. I've modified these static properties to use the approach elucidated in https://github.com/phetsims/wave-interference/issues/281#issue-392730446. Closing.