search

phetsims / number-line-integers

"Number Line: Integers" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 4 forks source link

Suggestion: Add a "Label" check box to the "Explore" screen #45

Closed kathy-phet closed 4 years ago

kathy-phet commented 4 years ago

It occurred to me while I was playing with this screen, that it would be useful to be able to hide the labels - just like we do on the second screen. I think @amanda-phet and I may have discussed this previously as it feels familiar? On each scene this would hide the label on the numberline, and additionally in the bank scene it would hide the value on the piggy bank.

This would add uniformity across the screens, and functionality - allowing students to do some estimating, or to reason without numbers about which was bigger.

I'm not sure what the default would be. Note on the Generic Screen, the default is currently off.

jbphet commented 4 years ago

This seems like a reasonable suggestion to me, and I particularly like the idea that it could be turned off and students would need to estimate values, which could help to develop more intuition about scale and about how the numbers are there whether or not they see them.

In my opinion, the default should be on.

@amanda-phet - since you're the head designer, I'm assigning to you for a 'yay' or 'nay' before I move forward with implementation.

amanda-phet commented 4 years ago

Sure, let's add labels. I agree they should be on by default on the Explore screen.

kathy-phet commented 4 years ago

@amanda-phet - If default is "labels" on on the Explore. It seems like we should match that default and make it "on" on the Generic too, since that is probably how most people will want to use it? What do you think?

amanda-phet commented 4 years ago

That's fine with me. I usually want it on every time I go to the Generic screen :)

jbphet commented 4 years ago

I've implemented a version of this and have two questions:

amanda-phet commented 4 years ago

Is the checkbox order okay?

Let's put Labels first, to match the Generic screen.

Shall we also hide the thermometer letter labels? I have opted not to do so in what I've done so far, since I don't see any value in hiding these, and it would make it harder to match the thermometer values to the positions on the number line.

My understanding of this checkbox is it shows/hides the labeled value on the number line. So, it would not be consistent for it to hide anything else, such as the letter labels.

kathy-phet commented 4 years ago

Amanda- to share the reason I recommended labels second is because you cannot actually hide the numberline at all on the generic screens and I didn’t think it was something you would want to do much of, so I thought put it at the top with default on since that would keep the order of the other boxes consistent with the generic screen?

Sent from my iPhone

On Nov 4, 2019, at 2:51 PM, Amanda McGarry notifications@github.com<mailto:notifications@github.com> wrote:

Is the checkbox order okay?

Let's put Labels first, to match the Generic screen.

Shall we also hide the thermometer letter labels? I have opted not to do so in what I've done so far, since I don't see any value in hiding these, and it would make it harder to match the thermometer values to the positions on the number line.

My understanding of this checkbox is it shows/hides the labeled value on the number line. So, it would not be consistent for it to hide anything else, such as the letter labels.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/phetsims/number-line-integers/issues/45?email_source=notifications&email_token=ABG4KZEQP24EVTWRJEBHJDDQSCKNRA5CNFSM4JFI2KA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDA22PY#issuecomment-549563711, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABG4KZADF34GIQTEXAWZO33QSCKNRANCNFSM4JFI2KAQ.

amanda-phet commented 4 years ago

the reason I recommended labels second is because you cannot actually hide the numberline at all on the generic screens and I didn’t think it was something you would want to do much of, so I thought put it at the top with default on since that would keep the order of the other boxes consistent with the generic screen?

I didn't know it was intentional. That is fine with me.

jbphet commented 4 years ago

Issue #51 is another good reason why the "Labels" checkbox should be below the "Number Line" checkbox - it should be disabled when the number line is not visible.

I think we're basically done with the process of adding this control, so I'm going to close the issue.