search

phetsims / number-line-integers

"Number Line: Integers" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 4 forks source link

Suggestion for the temperature scene #72

Closed kathy-phet closed 4 years ago

kathy-phet commented 4 years ago

I was reviewing RC.1, and had this one thought. Should the value readings and "A", "B", "C" labels in the temperature number line have the same color treatment as the "absolute value" labels get - so there is a constant color match, like in the other scenes? (sorry its post RC.1, just came to me now).

amanda-phet commented 4 years ago

I'm not sure I understand. Do you mean you would like the text to be color-coded? You can see in dev.7 that it used to be, but some colors require a light background and others require a dark background, and the flickering background didn't look good.

Please correct me if you're thinking of something else!

kathy-phet commented 4 years ago

I'm thinking color coded like this -- using the same solution as now is used for absolute value. image

amanda-phet commented 4 years ago

I see what you mean now.

@jbphet can we add the same color-coded background to the labels right next to the number line?

kathy-phet commented 4 years ago

I like the new style - it seems to really bring some nice pop/warmth to the numberline view. @amanda-phet what do you think?

amanda-phet commented 4 years ago

I like it. Thanks for making this change @jbphet !

jbphet commented 4 years ago

I've propagated the approved changes to the 1.0 release branch and will have this tested in the next RC.

KatieWoe commented 4 years ago

Looks good in rc.2