search

phetsims / number-line-integers

"Number Line: Integers" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 4 forks source link

Layering of absolute value labels #74

Closed KatieWoe closed 4 years ago

KatieWoe commented 4 years ago

For https://github.com/phetsims/QA/issues/465. I noticed that, on the first screen, the absolute value labels are on the same layer as their point. On the scene with the person, fish, and bird, this can lead to obscuring effects. I wonder if a different layering order may be better. (This does occur on the climate scene, but since the thermometers are larger it less of an issue.) possiblelayeringthought

ghost commented 4 years ago

Here's a related nitpick:

Screen Shot 2020-01-08 at 3 26 39 PM

For example, the values for the piggy banks overlap. The label is slightly transparent. On the one hand, this lets a user know that there is something behind the label. On the other hand, it looks bad. (There are other instances of this in the sim.)

I can't imagine that we'll change the label system given how complicated it would be. Any change would involve tradeoffs. I thought I would mention this anyway.

jbphet commented 4 years ago

Both of the things noted above are by design, and I recall discussing them and implementing this behavior. I'm going to unassign myself - @amanda-phet - please review and let me know if you think any changes are needed. If not, you are free to close.

amanda-phet commented 4 years ago

Yes this is by design. There isn't a perfect solution to labels that are close, and the top most object will the one in focus (so, if you click the bird it will be layered above the text for the girl).