search

phetsims / number-line-integers

"Number Line: Integers" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 4 forks source link

Thermometer labels can get slightly too long #80

Closed KatieWoe closed 4 years ago

KatieWoe commented 4 years ago

For https://github.com/phetsims/QA/issues/465 When strings are long the max width of the "A, B, C" labels for thermometers is a bit longer than the thermometer itself. The rtl string test is easiest to see, but any string test with more than one character will show it. These strings are unlikely to have long translations, so this is a lower priority issue. longthermometer

amanda-phet commented 4 years ago

@jbphet I discussed this with Katie and I think a max width makes sense here so the top of the letters don't get cut off.

jbphet commented 4 years ago

A max width value was already in place, but I've made it smaller and also a function of the thermometer width so that the size can be changed without having to also tweak the maxWidth value. It seems to be working well in my tests.

I wouldn't worry about anything more than a two-letter label as the max in further testing, since no translator in their right mind with use a long string here.

KatieWoe commented 4 years ago

StringTest double looks ok in rc.2