search

phetsims / number-line-integers

"Number Line: Integers" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 4 forks source link

Line is over dot on piggy bank scene and others #88

Closed KatieWoe closed 4 years ago

KatieWoe commented 4 years ago

Test device Dell Operating System Win 10 Browser Chrome Problem description For https://github.com/phetsims/QA/issues/468. May be related to https://github.com/phetsims/number-line-integers/issues/83. This did not occur in rc 2. On the piggy bank scene the line that leads from the piggy bank to the number line is now layered over the dot on the number line. This looks very off.

Visuals layeroverdot

Troubleshooting information:

!!!!! DO NOT EDIT !!!!! Name: ‪Number Line: Integers‬ URL: https://phet-dev.colorado.edu/html/number-line-integers/1.0.0-rc.3/phet/number-line-integers_en_phet.html Version: 1.0.0-rc.3 2020-01-24 00:21:22 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.130 Safari/537.36 Language: en-US Window: 1536x722 Pixel Ratio: 2.5/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 4096 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 32767x32767 OES_texture_float: true Dependencies JSON: {}
KatieWoe commented 4 years ago

Same sort of layering issue with absolute value on the elevation scene. Not in rc 2. sameissue EDIT: This occurred in rc 2 and is likely not an issue.

KatieWoe commented 4 years ago

labels

KatieWoe commented 4 years ago

moreover

KatieWoe commented 4 years ago

Odd layering that occurred in rc2 as well: oddlayering Does not need string test, just easier to reproduce with.

jbphet commented 4 years ago

The bank scene behavior was due to the re-layering that was done for #83. I revised things such that the point controllers are in front of the number line(s) in the "Elevation" and "Temperature" scenes, but behind it in the "Bank" scene. This seems to work, I'll leave it to QA to make sure there weren't any undesired consequences.

The combo box layering was due to a different issue, and has also been fixed.

KatieWoe commented 4 years ago

Looks good in rc.4. We decided https://github.com/phetsims/number-line-integers/issues/88#issuecomment-578231510 would not be addressed