search

phetsims / number-line-integers

"Number Line: Integers" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 4 forks source link

use MathSymbols in ComparisonStatementNode #92

Closed pixelzoom closed 4 years ago

pixelzoom commented 4 years ago

ComparisonStatementNode.js imports MathSymbols, but doesn't use it everywhere that it should:

35  const GREATER_THAN_STRING = '>';
36  const LESS_THAN_STRING = '<';

93 const comparisonOperatorNode = new Text( '>', {

This should be:

35  const GREATER_THAN_STRING = MathSymbols.GREATER_THAN;
36  const LESS_THAN_STRING = MathSymbols.LESS_THAN;

93 const comparisonOperatorNode = new Text( MathSymbols.GREATER_THAN, {
jbphet commented 4 years ago

Thanks for the suggestion @pixelzoom, this has now been addressed, closing.