search

phetsims / number-line-integers

"Number Line: Integers" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 4 forks source link

put listbox above range combo box? #93

Closed pixelzoom closed 4 years ago

pixelzoom commented 4 years ago

In the lower-right corner of the Generic screen, there's a ComboBox. It looks like this when the comb box's listbox is closed:

screenshot_72

When the listbox opens, it opens below the combo box button, covering the scene selection buttons. It will also be below the finger of touch users, possible obscuring the listbox.

screenshot_73

This seems like an excellent place to use the listPosition: 'above' feature of ComboBox. This would make the listbox appear above the combo box's button, and above the touch user's finger. It looks like this:

screenshot_74

This involves adding 1 line to the instantiation of rangeSelectionComboBox in NLIGenericScreenView.js:

listPosition: 'above',

amanda-phet commented 4 years ago

@pixelzoom it's funny you bring this up because the original mockups had that pointing upward, but I assumed the decision was based on whether there was room or not for the box to expand. I'd be happy to switch the direction for this sim and continue it in the other two.

jbphet commented 4 years ago

Thanks @pixelzoom - good suggestions.

@amanda-phet - I have implemented this change. Please check it out on master and make sure you're good with it. Assuming you are, please assign it back to me and I'll do a maintenance release. I figure we would need to do this before publishing the other Number Line sims anyway just to keep things consistent, so I might as well just do it now and let users start getting used to it.

amanda-phet commented 4 years ago

Looks good to me!

jbphet commented 4 years ago

I've done the maintenance release, this change is in place as of version 1.0.1. Closing.