phetsims / number-pairs

"Number Pairs" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

Initial pixel polishes #14

Closed catherinecarter closed 2 days ago

catherinecarter commented 1 month ago

These are initial pixel polishes:

marlitas commented 3 weeks ago

Move accordion box collapse/expand button to be 10 pixels from top and left edge

Let's chat about this. The mockups show a button layout when the accordion box is open and a different one when it is closed. I can't do both and what you're asking me to do would affect the way the title appears as well... maybe you're okay with that but I want to make sure.

catherinecarter commented 3 weeks ago

Thanks, Marla. I think the 10 pixels came from a "standard" I thought was true. But maybe I remembered wrong and it's 5 pixels? Whatever makes sense so the button is in the same place when open or closed. I checked a few sims and there seems to be a different number of pixels from the top/bottom/left edge when closed, so let's talk and decide on a good distance so it doesn't create a weird UI. Here are some examples:

marlitas commented 1 week ago

All of the pixel polishes in this issue have been handled. @catherinecarter let me know if there is any remaining work to be done.

catherinecarter commented 2 days ago

Closing - a new pixel polish issue was created in #30.