search

phetsims / number-pairs

"Number Pairs" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

Contents of Number Sentence accordion box shifts around. #28

Closed pixelzoom closed 1 week ago

pixelzoom commented 2 weeks ago

While playing around with #21, I noticed that the content in the Number Sentence accordion box shifts left/right a lot, and it's distracting. You might consider keeping the left edge of the content in a fixed position - there will be less stuff moving around. Here's a patch to accomplish that:

patch ```diff Subject: [PATCH] Update separator logic --- Index: js/common/view/NumberSentenceAccordionBox.ts IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== diff --git a/js/common/view/NumberSentenceAccordionBox.ts b/js/common/view/NumberSentenceAccordionBox.ts --- a/js/common/view/NumberSentenceAccordionBox.ts (revision af3e37c49dc05ba7ba8769a1d310f302fc844828) +++ b/js/common/view/NumberSentenceAccordionBox.ts (date 1730848896932) @@ -141,7 +141,9 @@ const options = optionize()( { titleNode: titleNode, + contentXMargin: 20, contentYMargin: 20, + contentAlign: 'left', minWidth: ACCORDION_BOX_WIDTH }, providedOptions ); super( richText, options ); ```
marlitas commented 1 week ago

I applied the patch. I believe this can be closed.