search

phetsims / number-play

"Number Play" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
3 stars 1 forks source link

Should the compare screen controls be swapped? #145

Closed chrisklus closed 2 years ago

chrisklus commented 2 years ago

I would like to consider swapping the placement of the scene buttons + checkbox with the locale switch + speech button. This would keep the speech button and locale switch consistent on all screens. This seems extra nice for when alternative input is added to this sim. The only drawback i see to this change is that the checkbox will be aligned by its text on the right instead of the nice edge of the checkbox on the left.

amanda-phet commented 2 years ago

Yes, let's do this. When we last talked about it, the organize buttons weren't there, so the speech button seemed weird on the left, and now it makes a ton of sense. Might need to play with the alignment on the right after the change happens, but this seems like a good change.

chrisklus commented 2 years ago

Completed in the above commit - I like it, want to take a look @amanda-phet?

amanda-phet commented 2 years ago

Looks good to me!