Open Nancy-Salpepi opened 2 years ago
A second example: If I hold a card containing multiple objects over the collection area and switch from scene 2 to scene 1, those cards will not return to collection area when I lift my finger.
Changing the radio buttons should interrupt all interactions with objects in the left/right accordion boxes. Probably by adding something like this in NumberPlayScreenView.ts:
// If the GroupAndLinkType changes, interrupt interaction with objects in these accordion boxes.
model.objectsGroupAndLinkTypeProperty.link( () => {
onesAccordionBox.interruptSubtreeInput();
this.objectsAccordionBox.interruptSubtreeInput();
} );
Adding blocks-sim-publication label to indicate this should be completed before starting dev testing. Since this is multitouch, it's not essential, but it sounds like @pixelzoom has a lead in https://github.com/phetsims/number-play/issues/173#issuecomment-1386434259.
Addressed as I described in https://github.com/phetsims/number-play/issues/173#issuecomment-1386434259. @chrisklus please review.
Thanks @pixelzoom, changes look good. Testing on my phone via phettest, all related problems seem fixed except what @Nancy-Salpepi described in https://github.com/phetsims/number-play/issues/173#issuecomment-1137281403. Since it's not causing any issues with the sims usability, I'm inclined to not fix it at this time. Marking this issue as deferred.
Test device iPad Air 2
Operating System 15.5
Browser safari
Problem description I noticed a couple of issues with multitouch when I am holding an object or button with one finger while changing scenes with another. For example, when holding a puppy card and changing from the locked scene to another one, the ones card will still move around when I move my finger (even though the puppy card may no longer be there).
Steps to reproduce
Visuals
https://user-images.githubusercontent.com/87318828/170276524-6791f021-8d51-4f07-9a0d-59c4f6c3b6c5.mov