search

phetsims / number-play

"Number Play" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
3 stars 1 forks source link

Non-standard "yellow" color for buttons #193

Closed pixelzoom closed 1 year ago

pixelzoom commented 1 year ago

In the Game, the color for the "Play" button and "New Challenge" buttons is Color.YELLOW. That violates the standard of using PhetColorScheme.BUTTON_YELLOW. I'm going to change to the standard.

This is also related to https://github.com/phetsims/number-suite-common/issues/7, where Color.YELLOW was incorrectly being used for the back button in the Game status bar.

pixelzoom commented 1 year ago

Similar problem for the SpeechSynthesisButton.

@chrisklus FYI.

pixelzoom commented 1 year ago

Since I've found 4 places that are using Color.YELLOW instead of PhetColorScheme.BUTTON_YELLOW, I'm going to clear this with @amanda-phet before making any changes.

@amanda-phet Did you intentionally specify Color.YELLOW instead of PhetColorScheme.BUTTON_YELLOW? If so, why is the standard color not appropriate for this sim?

Also note that we can't use Color.YELLOW for the Game's back button without making common-code changes.

amanda-phet commented 1 year ago

@amanda-phet Did you intentionally specify Color.YELLOW instead of PhetColorScheme.BUTTON_YELLOW? If so, why is the standard color not appropriate for this sim?

I did not. Thanks for checking! It is OK with me to follow through with changing Color.YELLOW to PhetColorScheme.BUTTON_YELLOW.

pixelzoom commented 1 year ago

Thanks @amanda-phet. I switched to PhetColorSchema.BUTTON_YELLOW where appropriate in the above commits. Assigning to @chrisklus so that he's aware of this change, feel free to close.

chrisklus commented 1 year ago

Thanks @pixelzoom, changes look good. I didn't know PhetColorSchema.BUTTON_YELLOW existed. Closing.