search

phetsims / number-play

"Number Play" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
3 stars 1 forks source link

Revise keys in number-play-strings_en.json #206

Closed pixelzoom closed 1 year ago

pixelzoom commented 1 year ago

Similar to https://github.com/phetsims/number-compare/issues/14 ...

In number-play-strings_en.json, this string key is not quite right. It should be "hearTotal".

"readAloud": {
    "value": "Hear Total"
  },

It should also be consistent with number-compare, where this change was made:

- "readAloud": {
+ "hearNumberSentence": {
    "value": "Hear Number Sentence"
  }

Since Number Play 1.0 was a prototype, and we've introduced other new strings, I'm going to assume that it's OK to change this string key.

pixelzoom commented 1 year ago

Done in the above commit. @chrisklus please view. Close if OK.

chrisklus commented 1 year ago

Changes look great, thanks @pixelzoom!