phetsims / number-play

"Number Play" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
3 stars 1 forks source link

Stacking of Objects onto a Filled Grid on the Lab Screen #231

Closed veillette closed 1 year ago

veillette commented 1 year ago

Test device DELL XPS

Operating System Windows 10

Browser Chrome

Problem description For https://github.com/phetsims/qa/issues/929:

On the lab screen, there is a rather sophisticated animation strategy to assign elements on the 2x5 grid. If one start adding say dogs to the grid, they are gracefully animated to position them into the grid. If an different element, say an apple, is set into the grid, it is gracefully animated to a position outside of the gridbox. However, once you fill out the 10 boxes (with dogs), the additional dogs can be stacked on top of the grid. My expectation for the behavior is that once the gridbox is full of dogs, the additional dogs would be gently animated away, just as it is done for the apples.

In addition, if you touch the gridbox after say adding a 13th dog, the gridbox will moveToFront, and the three unassigned dogs seem to vanish. Moving the gridbox reveals that they were merely underneath the gridbox.

I'll note that @KatieWoe did not seem trouble by this behavior, and I was not sure if I should file a bug in the first place. It is only a bug in the context that the other objects are so gracefully animated.

image

veillette commented 1 year ago

I'll mention that I file this bug report after talking to @chrisklus. I'll assign to him and @amanda-phet to decide if this is worth fixing.

zepumph commented 1 year ago

Thanks for the report, that makes a lot of sense! Committed above. Please confirm fixed on master and we will proceed with cherry-pick afterwards.

veillette commented 1 year ago

Thanks @zepumph. I can confirm that we have the desired behavior on master. Reassigning to @chrisklus to cherry-pick.

chrisklus commented 1 year ago

Cherry-picked in the above commits

zepumph commented 1 year ago

For QA: The same type of counting object should now behave the same way, getting pushed away from full tenFrames. Feel free to close.

Nancy-Salpepi commented 1 year ago

Looks good in rc.2 Closing.