search

phetsims / number-suite-common

"Number Suite Common" contains code for use by sims that are part of the Number Suite
GNU General Public License v3.0
0 stars 0 forks source link

5 usages of phet.joist.localeProperty should be factored out #21

Closed zepumph closed 1 year ago

zepumph commented 1 year ago

I don't like using the global for this. Most likely, we should just import it in the module system. We could also pass it through as parameters from a more central localtion. I'll start with importing though. Like this

https://github.com/phetsims/joist/blob/7b833a663f0c735e5e4a254ace9a1a693a5835ef/js/preferences/PreferencesModel.ts#L23

zepumph commented 1 year ago

From https://github.com/phetsims/number-suite-common/issues/15

zepumph commented 1 year ago

Tagging @chrisklus so he knows to use the module from here.