search

phetsims / number-suite-common

"Number Suite Common" contains code for use by sims that are part of the Number Suite
GNU General Public License v3.0
0 stars 0 forks source link

Address miscellaneous TODOs #29

Closed pixelzoom closed 1 year ago

pixelzoom commented 1 year ago

This issue is a catch-all for miscellaneous TODOs that did not have an associated GitHub issue. This issue covers the number-play, number-compare, number-suite, and counting-common repos.

These TODOs should be triaged for 1.0, identifying which ones need to be addressed. If any of them require significant work, please split out into a new issue.

Assigning to @chrisklus to triage.

chrisklus commented 1 year ago

Adding blocks-sim-publication label to indicate this should be completed before starting Number Compare and Number Play 1.0/1 dev testing.

pixelzoom commented 1 year ago

I took a quick look at all remaining TODOs. I don't see any that seem essential to address before publishing Number Play or Number Compare (https://github.com/phetsims/number-compare/issues/9) -- i.e. nothing that impacts UX or crashes the sim. @chrisklus you should definitely take a look too. But I'd be OK with changing this issue from "blocks-sim-publication" to "deferred".

zepumph commented 1 year ago

I wasn't able to preserve git history for LocaleSwitch, here is the last version when it was still over in number-suite-common. https://github.com/phetsims/number-suite-common/blob/6fd98ef94e1cbc1320d35721983651af37985ac3/js/common/view/LocaleSwitch.ts

zepumph commented 1 year ago

Handled a good amount above, we will keep working on them! 11 left.

zepumph commented 1 year ago

https://github.com/phetsims/number-compare/blob/78ed243599e0bd0a4af94d633663bec0a0bf20a9/js/compare/view/BlockValuesNode.ts#L17

zepumph commented 1 year ago

All TODO issues have been moved to side issues or handled in above commits. Closing