phetsims / number-suite-common

"Number Suite Common" contains code for use by sims that are part of the Number Suite
GNU General Public License v3.0
0 stars 0 forks source link

number-suite-common-strings_en.json contains strings that are not "common" #32

Closed pixelzoom closed 1 year ago

pixelzoom commented 1 year ago

These screen names do not belong in number-suite-common-strings_en.json. They are specific to number-play.

  "screen.ten": {
    "value": "Ten"
  },
  "screen.twenty": {
    "value": "Twenty"
  },
  "screen.game": {
    "value": "Game"
  },
pixelzoom commented 1 year ago

Looking at the other strings in number-suite-common-strings_en.json, the problem is not just the screen names. There are a lot of strings in here that are not common, and are used only by number-play.

Strings that are specific to (used only by) number-play or number-compare should be moved to the string file for those repos.

chrisklus commented 1 year ago

Thanks @pixelzoom, this is the result of me being a blockhead in https://github.com/phetsims/number-play/commit/a42135958aead021994bc12888b0337f8d7e11b4 and https://github.com/phetsims/number-suite-common/commit/3efd6108990b1e17387b517928e0f23e0fb27640.

chrisklus commented 1 year ago

Fixed in the above commits, closing.