search

phetsims / number-suite-common

"Number Suite Common" contains code for use by sims that are part of the Number Suite
GNU General Public License v3.0
0 stars 0 forks source link

Move all counting-common code into this repo #64

Open zepumph opened 1 year ago

zepumph commented 1 year ago

@chrisklus and I hit the straw that broke the camel's back about this separation of common code today over in https://github.com/phetsims/number-compare/issues/22, where we want code in counting-common and number-suite-common to use the same animation constants.

@chrisklus expressed interest in merging these two common repos together, and having make-a-ten just use a small subset of that code. This structure makes sense to me, and it also makes sense if we built number-suite sims first, and then wanted to come in and build make-a-ten as a separate spin-off, I think it is highly unlikely that we would factor out two common repos in that case.

I want to iterate strongly that this does not bring make-a-ten into the "number suite" collection of simulations, it just uses some shared common code.

We will want to work on this after we publish a number-play dev test.

zepumph commented 1 year ago

After discussion with @kathy-phet, this isn't in the cards right now. Marking as deferred. I'll note that I did try this out, and found that the script in perennial/js/scripts/copy-history-to-different-repo.js worked very well!