Mute Sound button always flips back to an "On" state

phetsims / ohms-law

"Ohm's Law" is an educational simulation in HTML5, by PhET Interactive Simulations.

http://phet.colorado.edu/en/simulation/ohms-law

GNU General Public License v3.0

5 stars 6 forks source link

Mute Sound button always flips back to an "On" state #117

Closed terracoda closed 6 years ago

terracoda commented 6 years ago

I just noticed that the Mute Sound button keeps flipping back to an "On" state, thus I get I cannot turn the sound off. In addition, I hear both alerts,

Sim sound off.
Sim sound on.

back to back.

This is likely a common code problem, but I found it in Ohm's Law, so posted it here.

terracoda commented 6 years ago

@zepumph I'll assign you, but please call in re-inforcements as needed. Tagging @jessegreenberg.

I imagine this is not an immediate issue for Ohm's Law, but more an issue for the upcoming finalized sonified version of John Travoltage see issue https://github.com/phetsims/john-travoltage/issues/300

jessegreenberg commented 6 years ago

@zepumph and I worked on this today as part of another issue, was definitely a common code problem. This button is working again, so closing this issue.