Update ohms-law with final changes from RIAW

phetsims / ohms-law

"Ohm's Law" is an educational simulation in HTML5, by PhET Interactive Simulations.

http://phet.colorado.edu/en/simulation/ohms-law

GNU General Public License v3.0

5 stars 6 forks source link

Update ohms-law with final changes from RIAW #123

Closed jessegreenberg closed 5 years ago

jessegreenberg commented 5 years ago

RIAW was recently successfully published with a11y features (alternative input, AT support, sound). OL and RIAW are quite similar, but don't share a common repo. So recent changes in RIAW for publication won't appear in this repo. We should scan recent RIAW commits and make sure that this repo has everything it needs (feature changes, bug fixes, performance improvements, ...).

jessegreenberg commented 5 years ago

I verified that the keyboard help dialog is within dev bounds with stringTest=double and stringTest=long (https://github.com/phetsims/resistance-in-a-wire/issues/203)

We will need to include changes for:

[x] https://github.com/phetsims/resistance-in-a-wire/issues/193
[x] https://github.com/phetsims/resistance-in-a-wire/issues/165
- OR verify that this is NOT necessary now that we support Chrome instead of FF with JAWS, see #118

jessegreenberg commented 5 years ago

OR verify that this is NOT necessary now that we support Chrome instead of FF with JAWS, see #118

Testing on my Windows 10 Laptop on Chrome with JAWS, I was not able to reproduce the issue. I don't think any changes from that issue need to be pulled into OL.

jessegreenberg commented 5 years ago

That is everything, this issue can be closed.