search

phetsims / ohms-law

"Ohm's Law" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/ohms-law
GNU General Public License v3.0
5 stars 6 forks source link

Remove list structure and group semantics around Slider Controls #155

Closed terracoda closed 4 years ago

terracoda commented 4 years ago

In https://github.com/phetsims/ohms-law/issues/153#issuecomment-583515016, I noted there was a coding error and in https://github.com/phetsims/ohms-law/issues/153#issuecomment-583528576 I also noticed there were some focus issues when using Home and End keys on the sliders when VO is enabled.

I am finding some focus inconsistencies on the list of slider controls, so I think it may be best to remove the list structure all together around the sliders and also remove the aria-labelledby that creates the group semantics as we did in GFL and GFLB. I think there was some weird issues with the sliders and lists and group semantics. Let me if your memory is different, I am wrong about this.

@zepumph assigning to you to remove the list and group semantics for the slider controls. Please re-assign if you have questions or if your recollection for the sliders in GFL and GFLB is different.

terracoda commented 4 years ago

@zepumph, I can't find the issue in GFLB or GFL where we made the decision to remove the list structure and group semantics on the sliders. Could you post it here if you think it is important.

terracoda commented 4 years ago

Found https://github.com/phetsims/gravity-force-lab/issues/187 while looking for something else.

zepumph commented 4 years ago

I removed the aria-labelledby association and the li container tags (replacing for divs). How does that look?

zepumph commented 4 years ago

Pinging here for a review before moving further for this sim.

terracoda commented 4 years ago

The sliders sound good and the pdom looks great. Thanks @zepumph. I think this issue is done.

terracoda commented 4 years ago

Back to you for @zepumph for closing.