search

phetsims / ohms-law

"Ohm's Law" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/ohms-law
GNU General Public License v3.0
5 stars 6 forks source link

Sliders not usable with keyboard after initial interaction #78

Closed jessegreenberg closed 7 years ago

jessegreenberg commented 7 years ago

In #74, @terracoda said

sliders keyboard accessible at first, but was not able to get focus on them tabbing back and forth through sim after initial interactions.

Using the a11y-view version with Safari 10.0.03 on Mac OS 10.12.3 (no screen reader)

http://www.colorado.edu/physics/phet/dev/html/ohms-law/1.4.0-dev.8/ohms-law-a11y-view.html

jessegreenberg commented 7 years ago

Indeed, reproduced myself in Safari, though not happening in chrome.

jessegreenberg commented 7 years ago

It is not happening in http://www.colorado.edu/physics/phet/dev/html/ohms-law/1.4.0-dev.8/ohms-law-a11y-view.html?accessibility, so likely something to do with the a11y view.

jessegreenberg commented 7 years ago

I added this line in the a11y-view html so that the sliders looked nicer in the copied DOM:

 mutation.target.removeAttribute( 'style' );

But it is removing the styling from the actual sliders in the PDOM, so Safari thinks they are invisible. Ill remove that line for now and accept not so good looking sliders until we have time to more thoroughly improve the a11y view representation.

jessegreenberg commented 7 years ago

Fixed in the above commits.