search

phetsims / ohms-law

"Ohm's Law" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/ohms-law
GNU General Public License v3.0
5 stars 6 forks source link

Keyboard order doesn't match visual order for control panel buttons #93

Closed zepumph closed 7 years ago

zepumph commented 7 years ago

@ariel-phet, as lead designer, I have a question.

Current button layout: image

Current Keyboard nav order:

These don't align for visual keyboard users. Up until this point the protocol/convention is that the reset all button should be the last item in the keyboard order before the nav bar. I think this is a good convention, but then it seems we are a bit stuck, unless we switch the buttons.

Should we switch the buttons?

Tagging @terracoda @jessegreenberg @emily-phet in case someone holds strong opinions.

ariel-phet commented 7 years ago

@zepumph yes it would be fine to switch those. In fact, probably desirable since the reset all button generally is located in the lower right of the sim.

terracoda commented 7 years ago

@zepumph, glad you brought this up. I was wondering about it, too. In John Travoltage, the buttons are the reversed.

zepumph commented 7 years ago

Sounds great! I love these quick issues to tackle questions about the sim. Thanks for fast turnaround on feedback.