search

phetsims / paper-land

Build and explore multimodal web interactives with pieces of paper!
https://phetsims.github.io/paper-land/
MIT License
19 stars 3 forks source link

Is the current Monaco editor acceptable? #12

Open brettfiedler opened 1 year ago

brettfiedler commented 1 year ago

Current web editor is Monaco editor (open source)

https://microsoft.github.io/monaco-editor/playground.html

brettfiedler commented 1 year ago

@jessegreenberg and I checked out the current version of react-monaco-editor being used (0.13.0) vs the latest (0.5.0).

Just updating the dependency in package.json and running npm install let me open the editor window, but when I chose a program from the dropdown, the whole window went black.

Does not seem to be a straightforward update.

brettfiedler commented 1 year ago

I think the API has blown up and become a lot more sophisticated. It also uses later version of react and embeds react dependencies inside of the installed package (react and react-dom subdirectories in 0.5.0 not present in 0.13.0) which are different than the react used for the main portions of the legacy tool.

brettfiedler commented 1 year ago

It'd be nice to update the Monaco editor to a newer version, but is not a priority. Open for contribution!