search

phetsims / paper-land

Build and explore multimodal web interactives with pieces of paper!
https://phetsims.github.io/paper-land/
MIT License
10 stars 1 forks source link

Allow Creator to push code to a space even when it is open for editing #215

Closed jessegreenberg closed 2 months ago

jessegreenberg commented 3 months ago

Paper Programs made it so that code won't update from the database while it is open in an editor on the Camera/Editor page. But this results in confusing/frustrating situations where you try to send your project from Creator and a particular program doesn't update because it is open.

Can we try to remove the "locking" feature for programs so that you can smoothly update them from while using Creator?

jessegreenberg commented 3 months ago

It seems like this might actually not be the case. While testing with @brettfiedler, I don't think we saw this. Closing until it becomes a problem again.

jessegreenberg commented 3 months ago

I am still hitting this unfortunately. If my cursor is in the Camera page editor it doesn't refresh when I push code from Creator. However, once I refresh the camera page, the code updates correctly.

EDIT: It may be that the code is correctly updated in the space but just NOT being updated in the editor. That might explain why we rarely notice this - code behavior would still be correct.

jessegreenberg commented 2 months ago

OK, this was fixed after the above commit. Updating the current code in the editor from database changes is safe because of changes in #107. Since the editor for the camera page is now readonly it is fine if it changes while open without user control.

Closing.