Closed arouinfar closed 8 years ago
I've exaggerated the Intro and Lab screen navbar icons (bottom)
The modified icons look a bit more recognizable in context
Here are the updated image files. These should be used in the navbar only -- no need to change the home screen icons. lab_navbar_icon.png intro_navbar_icon.png
Assigning to @veillette for implementation. Please let me know if you need an .ai file for this.
Thanks @arouinfar, the two navbar icons have been added. I updated the license file for the images and added you to the credits.
The sim builds with brand=phet without complaint.
Closing
We are hitting an assertion. The intro-navbar-icon does not have a correct aspect ratio. It size is 1133/778= 1.45629820051
var validAspectRatio = Math.abs( iconAspectRatio - navbarIconAspectRatio ) < tolerance || Math.abs( iconAspectRatio - homeScreenIconAspectRatio ) < tolerance;
assert && assert( validAspectRatio, 'NavigationBar icons for screen ' + screenIndex + ' did not have a valid aspect ratio.' );
The tolerance is 0.001
FYI, the icon must be a minimum of 147x100 and have an aspect ratio of 548/373=1.469. See https://github.com/phetsims/joist/issues/76
And there is a similar problem with the intro-navbar-icon :(
Assigning to @arouinfar to reissue new icons,
Let's try these @veillette. I resized them to 441x300.
Thanks @arouinfar , the new icons do not trigger assertions, and the branded sim builds without errors as well. Closing.
Master looks good! Thanks @veillette.
@ariel-phet pointed out that the navbar icons for the Intro and Lab screens are a little hard to interpret.
Self-assigning this issue to update the artwork for the icons. The size of the pendulums and vectors should be exaggerated a bit.