Pendulum Alignment Issues

phetsims / pendulum-lab

"Pendulum Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

4 stars 10 forks source link

Pendulum Alignment Issues #156

Closed veillette closed 7 years ago

veillette commented 8 years ago

From a conversation with @phet-steele on Skype

The left panels must be left aligned and share the same widths.
The right panels must be right aligned and share the same width.
For the upper right panel, the titles should be right aligned
also for the lower left panel, the titles (gravity and friction) should be aligned.

jonathanolson commented 7 years ago

Refactoring for left side would be particularly ugly without changes described in https://github.com/phetsims/sun/issues/276, I'll be waiting on that.

jonathanolson commented 7 years ago

Left-side alignment complete.

jonathanolson commented 7 years ago

I believe the alignment is as described in the pixel-polishing issue. @phet-steele, can you check over the alignment in http://www.colorado.edu/physics/phet/dev/html/pendulum-lab/1.0.0-dev.13/pendulum-lab_en.html?

phet-steele commented 7 years ago

👍 , thanks @jonathanolson. However, both vectors are labeled as "Velocity" on the lab screen. Can you fix this so I can more accurately check alignment of the left side, since Acceleration is a longer string?

jonathanolson commented 7 years ago

Fixed the string issue, sorry about that!