search

phetsims / pendulum-lab

"Pendulum Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 10 forks source link

sim relies on align:'right' default for Panels #158

Closed pixelzoom closed 7 years ago

pixelzoom commented 7 years ago

Related to https://github.com/phetsims/sun/issues/252, this sim relies on the old default of align:'right' for Panels. Below are the stack traces for occurrences that need to be checked. These are the occurrences noted when loading the sim in requirejs mode. If the sim creates Panels dynamically, you should do further checking with fuzzMouse.

>>>> sim relies on align:right
VM25559 Panel.js?bust=1472164978774:54 Error
    at PendulumSlidersNode.Panel [as constructor] (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164978774:50:15)
    at PendulumSlidersNode.PanelPendulumAbstract [as constructor] (http://localhost/~cmalley/GitHub/pendulum-lab/js/common/view/PanelPendulumAbstract.js?bust=1472164978774:24:11)
    at new PendulumSlidersNode (http://localhost/~cmalley/GitHub/pendulum-lab/js/common/view/PendulumSlidersNode.js?bust=1472164978774:119:27)
    at new PendulumLabView (http://localhost/~cmalley/GitHub/pendulum-lab/js/common/view/PendulumLabView.js?bust=1472164978774:62:31)
    at IntroScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/pendulum-lab/js/intro/IntroScreen.js?bust=1472164978774:34:34)
    at IntroScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164978774:134:25)
    at IntroScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164978774:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164978774:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164978774:439:13)
VM25559 Panel.js?bust=1472164978774:53 

>>>> sim relies on align:right
VM25559 Panel.js?bust=1472164978774:54 Error
    at SystemSlidersNode.Panel [as constructor] (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164978774:50:15)
    at SystemSlidersNode.PanelPendulumAbstract [as constructor] (http://localhost/~cmalley/GitHub/pendulum-lab/js/common/view/PanelPendulumAbstract.js?bust=1472164978774:24:11)
    at new SystemSlidersNode (http://localhost/~cmalley/GitHub/pendulum-lab/js/common/view/SystemSlidersNode.js?bust=1472164978774:70:27)
    at new PendulumLabView (http://localhost/~cmalley/GitHub/pendulum-lab/js/common/view/PendulumLabView.js?bust=1472164978774:67:30)
    at IntroScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/pendulum-lab/js/intro/IntroScreen.js?bust=1472164978774:34:34)
    at IntroScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164978774:134:25)
    at IntroScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164978774:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164978774:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164978774:439:13)
VM25559 Panel.js?bust=1472164978774:53 

>>>> sim relies on align:right
VM25559 Panel.js?bust=1472164978774:54 Error
    at ToolsControlPanelNode.Panel [as constructor] (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164978774:50:15)
    at ToolsControlPanelNode.PanelPendulumAbstract [as constructor] (http://localhost/~cmalley/GitHub/pendulum-lab/js/common/view/PanelPendulumAbstract.js?bust=1472164978774:24:11)
    at new ToolsControlPanelNode (http://localhost/~cmalley/GitHub/pendulum-lab/js/common/view/ToolsControlPanelNode.js?bust=1472164978774:53:27)
    at new PendulumLabView (http://localhost/~cmalley/GitHub/pendulum-lab/js/common/view/PendulumLabView.js?bust=1472164978774:92:33)
    at IntroScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/pendulum-lab/js/intro/IntroScreen.js?bust=1472164978774:34:34)
    at IntroScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164978774:134:25)
    at IntroScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164978774:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164978774:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164978774:439:13)
VM25559 Panel.js?bust=1472164978774:53 

>>>> sim relies on align:right
VM25559 Panel.js?bust=1472164978774:54 Error
    at PendulumSlidersNode.Panel [as constructor] (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164978774:50:15)
    at PendulumSlidersNode.PanelPendulumAbstract [as constructor] (http://localhost/~cmalley/GitHub/pendulum-lab/js/common/view/PanelPendulumAbstract.js?bust=1472164978774:24:11)
    at new PendulumSlidersNode (http://localhost/~cmalley/GitHub/pendulum-lab/js/common/view/PendulumSlidersNode.js?bust=1472164978774:119:27)
    at EnergyView.PendulumLabView [as constructor] (http://localhost/~cmalley/GitHub/pendulum-lab/js/common/view/PendulumLabView.js?bust=1472164978774:62:31)
    at new EnergyView (http://localhost/~cmalley/GitHub/pendulum-lab/js/energy/view/EnergyView.js?bust=1472164978774:29:21)
    at EnergyScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/pendulum-lab/js/energy/EnergyScreen.js?bust=1472164978774:34:34)
    at EnergyScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164978774:134:25)
    at EnergyScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164978774:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164978774:441:14)
    at Array.forEach (native)
VM25559 Panel.js?bust=1472164978774:53 

>>>> sim relies on align:right
VM25559 Panel.js?bust=1472164978774:54 Error
    at SystemSlidersNode.Panel [as constructor] (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164978774:50:15)
    at SystemSlidersNode.PanelPendulumAbstract [as constructor] (http://localhost/~cmalley/GitHub/pendulum-lab/js/common/view/PanelPendulumAbstract.js?bust=1472164978774:24:11)
    at new SystemSlidersNode (http://localhost/~cmalley/GitHub/pendulum-lab/js/common/view/SystemSlidersNode.js?bust=1472164978774:70:27)
    at EnergyView.PendulumLabView [as constructor] (http://localhost/~cmalley/GitHub/pendulum-lab/js/common/view/PendulumLabView.js?bust=1472164978774:67:30)
    at new EnergyView (http://localhost/~cmalley/GitHub/pendulum-lab/js/energy/view/EnergyView.js?bust=1472164978774:29:21)
    at EnergyScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/pendulum-lab/js/energy/EnergyScreen.js?bust=1472164978774:34:34)
    at EnergyScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164978774:134:25)
    at EnergyScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164978774:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164978774:441:14)
    at Array.forEach (native)
VM25559 Panel.js?bust=1472164978774:53 

>>>> sim relies on align:right
VM25559 Panel.js?bust=1472164978774:54 Error
    at ToolsControlPanelNode.Panel [as constructor] (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164978774:50:15)
    at ToolsControlPanelNode.PanelPendulumAbstract [as constructor] (http://localhost/~cmalley/GitHub/pendulum-lab/js/common/view/PanelPendulumAbstract.js?bust=1472164978774:24:11)
    at new ToolsControlPanelNode (http://localhost/~cmalley/GitHub/pendulum-lab/js/common/view/ToolsControlPanelNode.js?bust=1472164978774:53:27)
    at EnergyView.PendulumLabView [as constructor] (http://localhost/~cmalley/GitHub/pendulum-lab/js/common/view/PendulumLabView.js?bust=1472164978774:92:33)
    at new EnergyView (http://localhost/~cmalley/GitHub/pendulum-lab/js/energy/view/EnergyView.js?bust=1472164978774:29:21)
    at EnergyScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/pendulum-lab/js/energy/EnergyScreen.js?bust=1472164978774:34:34)
    at EnergyScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164978774:134:25)
    at EnergyScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164978774:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164978774:441:14)
    at Array.forEach (native)
VM25559 Panel.js?bust=1472164978774:53 

>>>> sim relies on align:right
VM25559 Panel.js?bust=1472164978774:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164978774:50:15)
    at new EnergyGraphNode (http://localhost/~cmalley/GitHub/pendulum-lab/js/energy/view/EnergyGraphNode.js?bust=1472164978774:132:11)
    at new EnergyView (http://localhost/~cmalley/GitHub/pendulum-lab/js/energy/view/EnergyView.js?bust=1472164978774:32:27)
    at EnergyScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/pendulum-lab/js/energy/EnergyScreen.js?bust=1472164978774:34:34)
    at EnergyScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164978774:134:25)
    at EnergyScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164978774:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164978774:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164978774:439:13)
    at http://localhost/~cmalley/GitHub/pendulum-lab/js/pendulum-lab-main.js?bust=1472164978774:40:15
VM25559 Panel.js?bust=1472164978774:53 

>>>> sim relies on align:right
VM25559 Panel.js?bust=1472164978774:54 Error
    at PendulumSlidersNode.Panel [as constructor] (VM25559 Panel.js?bust=1472164978774:50)
    at PendulumSlidersNode.PanelPendulumAbstract [as constructor] (VM25573 PanelPendulumAbstract.js?bust=1472164978774:24)
    at new PendulumSlidersNode (VM25486 PendulumSlidersNode.js?bust=1472164978774:119)
    at LabView.PendulumLabView [as constructor] (VM25422 PendulumLabView.js?bust=1472164978774:62)
    at LabView.EnergyView [as constructor] (VM25415 EnergyView.js?bust=1472164978774:29)
    at new LabView (VM25421 LabView.js?bust=1472164978774:32)
    at LabScreen.Screen.call.backgroundColor [as createView] (VM25408 LabScreen.js?bust=1472164978774:36)
    at LabScreen.initializeView (VM25418 Screen.js?bust=1472164978774:134)
    at LabScreen.initializeModelAndView (VM25418 Screen.js?bust=1472164978774:151)
    at initializeScreen (VM25409 Sim.js?bust=1472164978774:441)
VM25559 Panel.js?bust=1472164978774:53 

>>>> sim relies on align:right
VM25559 Panel.js?bust=1472164978774:54 Error
    at SystemSlidersNode.Panel [as constructor] (VM25559 Panel.js?bust=1472164978774:50)
    at SystemSlidersNode.PanelPendulumAbstract [as constructor] (VM25573 PanelPendulumAbstract.js?bust=1472164978774:24)
    at new SystemSlidersNode (VM25493 SystemSlidersNode.js?bust=1472164978774:70)
    at LabView.PendulumLabView [as constructor] (VM25422 PendulumLabView.js?bust=1472164978774:67)
    at LabView.EnergyView [as constructor] (VM25415 EnergyView.js?bust=1472164978774:29)
    at new LabView (VM25421 LabView.js?bust=1472164978774:32)
    at LabScreen.Screen.call.backgroundColor [as createView] (VM25408 LabScreen.js?bust=1472164978774:36)
    at LabScreen.initializeView (VM25418 Screen.js?bust=1472164978774:134)
    at LabScreen.initializeModelAndView (VM25418 Screen.js?bust=1472164978774:151)
    at initializeScreen (VM25409 Sim.js?bust=1472164978774:441)
VM25559 Panel.js?bust=1472164978774:53 

>>>> sim relies on align:right
VM25559 Panel.js?bust=1472164978774:54 Error
    at ToolsControlPanelNode.Panel [as constructor] (VM25559 Panel.js?bust=1472164978774:50)
    at ToolsControlPanelNode.PanelPendulumAbstract [as constructor] (VM25573 PanelPendulumAbstract.js?bust=1472164978774:24)
    at new ToolsControlPanelNode (VM25494 ToolsControlPanelNode.js?bust=1472164978774:53)
    at LabView.PendulumLabView [as constructor] (VM25422 PendulumLabView.js?bust=1472164978774:92)
    at LabView.EnergyView [as constructor] (VM25415 EnergyView.js?bust=1472164978774:29)
    at new LabView (VM25421 LabView.js?bust=1472164978774:32)
    at LabScreen.Screen.call.backgroundColor [as createView] (VM25408 LabScreen.js?bust=1472164978774:36)
    at LabScreen.initializeView (VM25418 Screen.js?bust=1472164978774:134)
    at LabScreen.initializeModelAndView (VM25418 Screen.js?bust=1472164978774:151)
    at initializeScreen (VM25409 Sim.js?bust=1472164978774:441)
VM25559 Panel.js?bust=1472164978774:53 

>>>> sim relies on align:right
VM25559 Panel.js?bust=1472164978774:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164978774:50:15)
    at new EnergyGraphNode (http://localhost/~cmalley/GitHub/pendulum-lab/js/energy/view/EnergyGraphNode.js?bust=1472164978774:132:11)
    at LabView.EnergyView [as constructor] (http://localhost/~cmalley/GitHub/pendulum-lab/js/energy/view/EnergyView.js?bust=1472164978774:32:27)
    at new LabView (http://localhost/~cmalley/GitHub/pendulum-lab/js/lab/view/LabView.js?bust=1472164978774:32:16)
    at LabScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/pendulum-lab/js/lab/LabScreen.js?bust=1472164978774:36:34)
    at LabScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164978774:134:25)
    at LabScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164978774:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164978774:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164978774:439:13)
VM25559 Panel.js?bust=1472164978774:53 

>>>> sim relies on align:right
VM25559 Panel.js?bust=1472164978774:54 Error
    at ArrowsPanelNode.Panel [as constructor] (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164978774:50:15)
    at ArrowsPanelNode.PanelPendulumAbstract [as constructor] (http://localhost/~cmalley/GitHub/pendulum-lab/js/common/view/PanelPendulumAbstract.js?bust=1472164978774:24:11)
    at new ArrowsPanelNode (http://localhost/~cmalley/GitHub/pendulum-lab/js/lab/view/ArrowsPanelNode.js?bust=1472164978774:56:27)
    at new LabView (http://localhost/~cmalley/GitHub/pendulum-lab/js/lab/view/LabView.js?bust=1472164978774:35:27)
    at LabScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/pendulum-lab/js/lab/LabScreen.js?bust=1472164978774:36:34)
    at LabScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164978774:134:25)
    at LabScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164978774:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164978774:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164978774:439:13)
pixelzoom commented 7 years ago

None of the above call sites use the minWidth option, so their behavior will be unaffected. Closing.