search

phetsims / pendulum-lab

"Pendulum Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 10 forks source link

Dev boundary has inconsistent width #167

Closed arouinfar closed 7 years ago

arouinfar commented 7 years ago

Using ?dev, the width on the home screen does not match the width within the sim. image image

@jonathanolson not sure how much of an issue this is, but the inconsistency makes it a bit harder to recommend layout changes for #165.

jonathanolson commented 7 years ago

This is caused by the sim having specified an atypical (I believe older) layout bounds (with a different aspect ratio).

The home screen has the normal (default) one. See https://github.com/phetsims/pendulum-lab/issues/165#issuecomment-315466865 for details

jonathanolson commented 7 years ago

Requested permission for me to switch to the normal layout bounds (normal aspect ratio) in that issue, assigning for that question here.

jonathanolson commented 7 years ago

There is NO reason why the sim should be at a non-standard aspect ratio.

Saw this in another issue, assigning myself for the change.

jonathanolson commented 7 years ago

Committed initial changes for this.

Note that the "dev" bounds for the home screen do still include the navbar for the home screen, while they don't include the navbar for sim screens. This is expected, and now the aspect ratios match (left/right layout bounds locations won't change).