search

phetsims / pendulum-lab

"Pendulum Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 10 forks source link

Add legend to energy graph #168

Closed arouinfar closed 7 years ago

arouinfar commented 7 years ago

To maximize the amount of available vertical space, abbreviate the labels in the Energy graph and add a legend dialog, similar to Masses and Springs. image image

Self-assigning to mock up.

arouinfar commented 7 years ago

@jonathanolson here's a mockup of the Energy Graph with the info button (uses font awesome fa-info-circle) and the Energy Legend dialog. The zoom buttons differ slightly from master, but that is unintentional. image

image

jonathanolson commented 7 years ago

Implemented, let me know how it looks.

arouinfar commented 7 years ago

Love it @jonathanolson! The only issue is that the close button appears to be out of bounds: image

jonathanolson commented 7 years ago

I pushed a common-code fix to joist in https://github.com/phetsims/joist/issues/346, can you try pulling common repos and retesting?

arouinfar commented 7 years ago

Thanks for the clarification. Will do @jonathanolson.

arouinfar commented 7 years ago

Much better now! Thanks @jonathanolson!