phetsims / pendulum-lab

"Pendulum Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 10 forks source link

Slider pixel polishing #179

Closed arouinfar closed 6 years ago

arouinfar commented 6 years ago

@jonathanolson as discussed in today's design meeting, here's a mockup of the sliders in the style of Projectile Motion.

image

Here are the changes overlayed on dev.14 image

Please let me know if you have any questions!

arouinfar commented 6 years ago

Just as a heads up -- @jonathanolson I tried my best to match the Projectile Motion style, but things in my mockups may be slightly off. If you run into anything fishy, do what you think is best, and don't worry about matching the mockups exactly.

jonathanolson commented 6 years ago

Implemented for length/mass.

I don't see a mock-up for how Gravity would look for the first two screens. Should it just have no readout, and the different labels?

arouinfar commented 6 years ago

Oops, sorry about that @jonathanolson! For the first two screens, omit the gravity readout and change the labels to "None" and "Lots". Would you like me to mock it up?

jonathanolson commented 6 years ago

No need, I understand.

arouinfar commented 6 years ago

Took a look at master, and the updated sliders are looking good. We may want to bump up the max/min labels up a px or two, though. They're a little on the small side.

jonathanolson commented 6 years ago

Bumped up tick labels by 2, let me know if it looks better now.

arouinfar commented 6 years ago

Looking much better, thanks!!

jonathanolson commented 6 years ago

Implemented, let me know how it looks (also pull scenery-phet)

I placed the planet X "question" where the slider goes (as I couldn't see any better place), and the readout is suppressed (for gravity) when planet X is elected.

arouinfar commented 6 years ago

Looks really good @jonathanolson! The location of the Planet X question looks great, and I don't mind the combobox being below the gravity slider. The only thing that looks a bit off to me are the gravity tweakers on the first two screens. Seems a bit odd/useless to have fine adjustment of an ill-defined parameter.

@jonathanolson can we kill the gravity tweakers on Intro and Energy?

jonathanolson commented 6 years ago

Removed tweakers. Also adjusted the friction slider to use the same system for proper alignment, and cleaned up some code usage.

Let me know if it looks good (and if it's ready for RC).

arouinfar commented 6 years ago

Looks good! I think it's ready for RC, but maybe @kathy-phet would like to take a look at the latest changes first?

kathy-phet commented 6 years ago

@jonathanolson - This is looking very nice, thanks! One tweak request -- the font size for the readout value looks smaller than on projectile motion. Can you look at the difference and try to match them? I'm not worried about the tickmark values being a smaller font, but I would like the readout of the actual value to be similar to projectile motion font size. This may mean that the slider spacing between the bottom of one slider control and the label row of the next slider control needs to be tweaked a few pixels to ensure that there is adequate negative space there.

image image

jonathanolson commented 6 years ago

Increased readout font size to match. Spacing should have adjusted itself automatically.

Let me know if that looks good, or if any further changes would be helpful.

Somewhat related, the gray stroke around the readouts kind of blends in against the gray background, and could be slightly darkened. Thoughts?

kathy-phet commented 6 years ago

I think the stroke is fine as is.

But can you also increase the font readout for gravity on the lab screen?

jonathanolson commented 6 years ago

Changed (it looks like the readout was going past the maximum width set for i18n purposes). I've allocated more room for the readouts (so the gravity readout fits without being sized down).

kathy-phet commented 6 years ago

looks great. closing