search

phetsims / pendulum-lab

"Pendulum Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 10 forks source link

A bit more negative space in Length/Mass panel #185

Closed ariel-phet closed 6 years ago

ariel-phet commented 6 years ago

@jonathanolson @kathy-phet @arouinfar

To my eye, the Length/Mass panel looks a bit cramped and could use a bit of "breathing room" both between the Length and Mass and adjustments and between the two groupings of Mass/Length 1 and Mass length 2. In particular the sliders feel very vertically close to the readouts.

For comparison

Here is the sim now

pl

And here are some slight adjustments to negative space

pl2

It seems we have the room? Was there a reason to make these so tight?

ariel-phet commented 6 years ago

Additionally I would consider bumping up the slider thumb/track vertical size slightly. These seem awfully small. The work just fine on iPad, but just seem a bit tiny compared to our norm for sliders. Perhaps a pixel or two larger? Am I missing some vertical space concern?

ariel-phet commented 6 years ago

https://github.com/phetsims/QA/issues/45

arouinfar commented 6 years ago

Am I missing some vertical space concern?

No, not currently @ariel-phet. Quite some time ago, the panels on the Lab screen crowded the resetAllButton so much that the button was reduced to 75% of its normal size. Seems like we overcorrected a bit. I think your 2nd mockup showing the increased vertical spacing looks much better. Thanks!

Additionally I would consider bumping up the slider thumb/track vertical size slightly.

We've increased the size of the slider thumb a bit, but it still looks a bit smaller than normal. In general, the sliders were modeled after Projectile Motion, which has small tick marks at the min/max. Not sure if the tick size matches Projectile Motion, though.

@jonathanolson please

arouinfar commented 6 years ago

@kathy-phet and I reviewed this issue together, so unassigning her too.

jonathanolson commented 6 years ago

Increase the vertical spacing to match @ariel-phet's 2nd mockup in #185 (comment) Increase size of slider thumbs to match Projectile Motion

Done, let me know how it looks.

Increase size of min/max tick marks on length/mass sliders to match Projectile Motion

Tick sizes are identical (5 view units tall).

ariel-phet commented 6 years ago

@jonathanolson version on Master looks good to me, thanks for the quick changes. Closing