search

phetsims / pendulum-lab

"Pendulum Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 10 forks source link

Change stacking order of total energy bar #202

Open arouinfar opened 6 years ago

arouinfar commented 6 years ago

In https://github.com/phetsims/masses-and-springs/issues/200, the bars within total energy were reordered so that the thermal energy was at the top and the KE was at the bottom.

@ariel-phet provided the following rationale:

(1) I like the thermal energy coming "off the top" - I think this gives the feeling that as it grows it is "shriking" the available amounts of mechanical energy, which feels natural to me.

(2) Putting KE on the bottom feels like a more natural mapping to me, it is easir for me to interpret that as the motion

(3) I also feel that the elastic energy now feels better mapped to the spring movement in the total stack

I think these changes make the total energy bar far more intuitive and interpretable, so I would like to make a similar change in Pendulum Lab the next time it's up for a maintenance release.

The stacking order would be reversed so that the thermal energy is on top and the kinetic energy is on the bottom.

jonathanolson commented 6 years ago

Done, can you verify?

arouinfar commented 6 years ago

Stacking order looks good @jonathanolson, but the graphs appears to have been shifted down a bit. image

jonathanolson commented 6 years ago

Can you try pulling griddle? I believe this was a bug we fixed in common code.

arouinfar commented 6 years ago

Ah, didn't think to pull common repos, thanks @jonathanolson. Looks wonderful now!

jonathanolson commented 6 years ago

Does this warrant a maintenance release, or should we close this issue?

arouinfar commented 6 years ago

@jonathanolson, it's not high priority, though I do think it would be nice to do a maintenance release when time allows.