search

phetsims / pendulum-lab

"Pendulum Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 10 forks source link

'grunt published-README' not run in 1.0 branch #204

Closed pixelzoom closed 4 years ago

pixelzoom commented 5 years ago

The 1.0 branch of this sim still indicate that the sim is unpublished.

The master checklist for sims says:

  • [ ] README.md updated using grunt published-README (in master and release branch)
pixelzoom commented 5 years ago

This appears to be a problem with grunt production. It runs grunt published-README in master, but not in the release branch.

jonathanolson commented 5 years ago

I was not aware that this needs to be run in both branches (or that anyone would check the README in a branch). Is this something we should do? (tagging for dev meeting).

pixelzoom commented 5 years ago

Why would you want the README to be bogus, even in a non-master branch?

jonathanolson commented 5 years ago

Untagging, will figure out a way to patch it in both places.

pixelzoom commented 4 years ago

Looks like this was done at some point, though there's no commit associated with this issue. Closing.