search

phetsims / pendulum-lab

"Pendulum Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 10 forks source link

change '{0}' to SunConstants.VALUE_NAMED_PLACEHOLDER #210

Open pixelzoom opened 5 years ago

pixelzoom commented 5 years ago

Noted in https://github.com/phetsims/scenery-phet/issues/446#issuecomment-460732512.

Since NumberDisplay and NumberControl now support {{value}}, there are 4 replacements involving '{0}' that should be changed to NumberDisplay.NAMED_PLACEHOLDER:

screenshot_1029

In the future, such replacements could be avoided altogether by using '{{value}}' in the string file. For example:

// instead of this:
  "metersPattern": {
    "value": "{{meters}} m"
  },

// use this:
  "metersPattern": {
    "value": "{{value}} m"
  },
pixelzoom commented 5 years ago

This constant was moved to SunConstants.VALUE_NAMED_PLACEHOLDER in https://github.com/phetsims/sun/issues/474.