search

phetsims / pendulum-lab

"Pendulum Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 10 forks source link

Use Stopwatch and StopwatchNode #216

Open samreid opened 4 years ago

samreid commented 4 years ago

From https://github.com/phetsims/gas-properties/issues/170: PENDULUM_LAB/StopwatchNode now has features supported in SCENERY_PHET, and should be updated accordingly.

I've made these changes and will reassign to responsible dev for review after pushing.

samreid commented 4 years ago

@jonathanolson can you please review at your convenience?

jonathanolson commented 4 years ago

Looks good, thanks!

samreid commented 4 years ago

There are still TODOs marked for this issue, discovered during https://github.com/phetsims/chipper/issues/946

samreid commented 4 years ago

It looks like Pendulum lab has its own stopwatch. That should be deleted and the scenery-phet common code one should be used instead. Unassigning until we return focus to this sim.

pixelzoom commented 3 years ago

@samreid This issue is ready-for-review but unassigned. Should ready-for-review be removed?

samreid commented 3 years ago

I think this issue should remain open but not ready for review. It's unclear how we will want to treat PeriodTimer (which currently extends PENDULUM_LAB/Stopwatch) and PeriodTimerNode, but we will likely want to make sure things are working nicely during phet-io instrumentation.

arouinfar commented 1 year ago

We were looking at examples of StopwatchNode during today's Projectile Motion design meeting, and discovered the published version of Pendulum Lab was using a slightly different version of the component. @matthew-blackman requested that I open an assign an issue to him to investigate, but looks like there's already an issue for it.