search

phetsims / pendulum-lab

"Pendulum Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 10 forks source link

Period Timer should be able to immediately re-record period #24

Closed arouinfar closed 9 years ago

arouinfar commented 9 years ago

Currently, the period timer will not re-record the pendulum's period until after the period trace has completely faded away.

To reproduce: 1) While pendulum 1 is swinging, start the period timer. 2) After period finishes recording, immediately press on the play/record button to start again. The play/record will turn into the reset button, but the period will not be recorded: image

Desired behavior: If the play/record button is pressed immediately after the period timer finishes recording, the now-fading period trace should immediately disappear (instead of continuing to fade) and the timer should start recording/tracing the new period. There shouldn't be a required "cooling down" period in which the timer is inoperable.

andrey-zelenkov commented 9 years ago

Added immediate re-record of period for Period Timer. Reassign to @arouinfar for verification.

arouinfar commented 9 years ago

Fixed, closing.

arouinfar commented 9 years ago

When trying to verify #77, I found this issue (as described in the original post) to be present in the latest pull from git-dev. Reopening and assigning to @andrey-zelenkov.

arouinfar commented 9 years ago

Issue reopened in error (remote pull of git-dev is not working), so closing.