search

phetsims / pendulum-lab

"Pendulum Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 10 forks source link

Mock-up screenshots should not be included #26

Closed jonathanolson closed 9 years ago

jonathanolson commented 9 years ago

They are currently loaded into the sim in the main:

  var screenshot1 = require( 'image!PENDULUM_LAB/pendulum-lab-screen-1.png' );
  var screenshot2 = require( 'image!PENDULUM_LAB/pendulum-lab-screen-2.png' );
  var screenshot3 = require( 'image!PENDULUM_LAB/pendulum-lab-screen-3.png' );

then passed to each screen and to PendulumLabView. They should not be in the simulation at all (as it increases the download size), and the code related to the mock-ups should be removed.

andrey-zelenkov commented 9 years ago

Removed mock-up screenshot images from simulation. Reassign to @jonathanolson for verification.

jonathanolson commented 9 years ago

Looks good, thanks!