search

phetsims / pendulum-lab

"Pendulum Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 10 forks source link

Reset handling #39

Closed jonathanolson closed 9 years ago

jonathanolson commented 9 years ago

Generally, calling prototype methods on non-self objects is highly discouraged. Instead of code like:

PropertySet.prototype.reset.call( this.rulerModel );

we should have:

this.rulerModel.reset();

and similar for all usages like that.

andrey-zelenkov commented 9 years ago

Reset handling changed (avoid calling prototype methods). Reassign to @jonathanolson for verification.

jonathanolson commented 9 years ago

Looks good, thanks!