phetsims / pendulum-lab

"Pendulum Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 10 forks source link

EMPTY_SHAPE potentially unnecessary? #48

Closed jonathanolson closed 9 years ago

jonathanolson commented 9 years ago

EMPTY_SHAPE is set to new Shape() and only used for Paths. Using null would work just as well. Any reason EMPTY_SHAPE is used instead?

andrey-zelenkov commented 9 years ago

Remove unnecessary EMPTY_SHAPE. Reassign to @jonathanolson for verification.

jonathanolson commented 9 years ago

Looks good, thanks!