search

phetsims / pendulum-lab

"Pendulum Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 10 forks source link

Pendulum.angle documentation #49

Closed jonathanolson closed 9 years ago

jonathanolson commented 9 years ago

Since we are using sign-dependent code like the following:

newAngle * oldAngle < 0

where there is a significant difference between (pi * -pi) and (3pi * pi), even if the angles are the same mod 2pi.

Please document the acceptable range and where it is rounded.

andrey-zelenkov commented 9 years ago

Added Pendulum.angle documentation. Reassign to @jonathanolson for verification.

jonathanolson commented 9 years ago

Could the documentation be added where Pendulum.angle is declared?

andrey-zelenkov commented 9 years ago

Move 'angle' property description comments to Pendulum.angle. Reassign to @jonathanolson for verification.

jonathanolson commented 9 years ago

Looks great, thanks!