search

phetsims / pendulum-lab

"Pendulum Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 10 forks source link

PeriodTrace's anticlockwise flags #51

Closed jonathanolson closed 9 years ago

jonathanolson commented 9 years ago

It seems like PeriodTrace could be simplified with a single anticlockwise flag (for the intial movement). Every anticlockwise flag for [1], [2], and [3] are determined by [0]'s anticlockwise. Additionally, every access of anticlockwise in the node has a specific index specified, so the signs can be applied there.

Is there another reason anticlockwise is duplicated?

andrey-zelenkov commented 9 years ago

Remove unused 'anticlockwise' flags and simplify period trace model. Reassign to @jonathanolson for verification.

jonathanolson commented 9 years ago

Looks great, thanks!