String variables should start with a lowercase character

phetsims / pendulum-lab

"Pendulum Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

4 stars 10 forks source link

Closed jonathanolson closed 9 years ago

jonathanolson commented 9 years ago

For example:

var EarthString = require( 'string!PENDULUM_LAB/earth' );

should be changed to something like:

var earthString = require( 'string!PENDULUM_LAB/earth' );

Generally an upper-case first character is reserved for constants (all upper case) or types (we can't do "new EarthString()")

andrey-zelenkov commented 9 years ago

String variables names fixes (change first character to lowercase). Reassign to @jonathanolson for verification.

jonathanolson commented 9 years ago

Looks great, thanks!