search

phetsims / pendulum-lab

"Pendulum Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 10 forks source link

Hardcoded Strings in PendulumSlidersNode #63

Closed aaronsamuel137 closed 9 years ago

aaronsamuel137 commented 9 years ago

During code review #56, I noticed the use of hardcoded strings "Length" and "Mass" instead of taking strings from the strings file.

         // add length slider label
              new Text( StringUtils.format( pattern_0propertyName_1pendulumNumber, 'Length', (pendulumIndex + 1).toString() ), {
                font: FONT_TITLE,
                fill: pendulum.color
              } ),

...

              new Text( StringUtils.format( pattern_0propertyName_1pendulumNumber, 'Mass', (pendulumIndex + 1).toString() ), {
                font: FONT_TITLE,
                fill: pendulum.color
              } ),
andrey-zelenkov commented 9 years ago

Replace hardcoded 'mass' and 'length' strings. Reassign to @aaronsamuel137 for verification.

aaronsamuel137 commented 9 years ago

Looks great! Closing