search

phetsims / pendulum-lab

"Pendulum Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 10 forks source link

Should numbers be translatable? #65

Closed aaronsamuel137 closed 8 years ago

aaronsamuel137 commented 9 years ago

During code review #56, I noticed that numbers are cast to strings and put into TextNodes in a few places in this sim.

          new Text( (pendulumIndex + 1).toString(), { font: FONT, fill: 'white', centerY: RECT_SIZE.height / 4, centerX: 0 } ),

I'm not sure that we need to translate these or not, but I want to at least make an issue that we can come back to when we get further along in the translation process.

Leaving unassigned for now.

jonathanolson commented 8 years ago

I could imagine translators wanting to have the equivalent of 'First Mass' / 'Primary Mass' / etc. instead of 'Mass 1', but I'll leave the translation decision up to design.

arouinfar commented 8 years ago

I think it's best to use the same convention as Hooke's Law, so the the Mass and Length strings would be remain the equivalent of "Mass 1" or "Length 2" like in the situation below. image