phetsims / pendulum-lab

"Pendulum Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 10 forks source link

Period trace disappears even when sim is paused #96

Closed phet-steele closed 7 years ago

phet-steele commented 9 years ago

@arouinfar, I would add the question label to this but I don't have the permission to on this repo. Would it be more beneficial to keep the period drawn when the sim is paused? It certainly would make more sense.

arouinfar commented 9 years ago

Great suggestion, @phet-steele! I agree that it would make more sense for the period trace to remain on screen while the sim is paused. If you pause the sim before the period has been completed, the trace will not fade away (left). However, if the sim is paused after tracing a full period, the trace will fade away (right). image image While the current behavior is consistent with the Flash sim, it would be better if the trace always remains on screen while paused.

jonathanolson commented 8 years ago

Looks like this was already fixed.

phet-steele commented 8 years ago

However, if the sim is paused after tracing a full period, the trace will fade away (right).

@arouinfar why?

arouinfar commented 8 years ago

@phet-steele I was describing what the Flash sim did. Can't say that I can speak to the motivation there...

I also said

While the current behavior is consistent with the Flash sim, it would be better if the trace always remains on screen while paused.

I believe the outcome of this issue was supposed to keep the trace from fading away once the sim is paused. However, it looks like that functionality doesn't exist in the latest dev. I'll go ahead and reopen the issue, but I'm not sure who I should assign this to...

arouinfar commented 8 years ago

@veillette if this issue is within the scope of your work on Pendulum Lab, please take care of it.

jonathanolson commented 7 years ago

I'll make the "period trace won't continue fading away while the sim is paused" change.

jonathanolson commented 7 years ago

Should be implemented.

arouinfar commented 7 years ago

👍