zepumph
commented
3 years ago When I apply this patch, I get messages like this for grunt print-phet-io-links:
Michael ~/PhET/git/perennial (master)
$ grunt print-phet-io-links
Running "print-phet-io-links" task
[winston] Attempt to write logs with no transports {"message":"getting phet-io metadata request with https://phet.colorado.edu/services/metadata/phetio?&active=true&latest=true","level":"info"}
[winston] Attempt to write logs with no transports {"message":"git checkout 1.2 on balancing-act","level":"info"}
[winston] Attempt to write logs with no transports {"message":"running git checkout 1.2 from ../balancing-act","level":"debug"}
[winston] Attempt to write logs with no transports {"message":"stdout: Your branch is behind 'origin/1.2' by 8 commits, and can be fast-forwarded.\n (use \"git pull\" to update your local branch)\n","level":"debug"}
[winston] Attempt to write logs with no transports {"message":"stderr: Switched to branch '1.2'\n","level":"debug"}
[winston] Attempt to write logs with no transports {"message":"getting dependencies.json for balancing-act","level":"info"}
When I add this patch, I then get messages that look like this:
Index: js/grunt/Gruntfile.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- js/grunt/Gruntfile.js (revision 00c8e4b97f5360c17efa7e4e0e6b819c5c0ae64d)
+++ js/grunt/Gruntfile.js (date 1605568794317)
@@ -43,6 +43,8 @@
module.exports = function ( grunt ) {
+ winston.add( new winston.transports.Console() );
+
if ( grunt.option( 'debug' ) ) {
winston.default.transports.console.level = 'debug';
}
Michael ~/PhET/git/perennial (master)
$ grunt print-phet-io-links
Running "print-phet-io-links" task
{"message":"getting phet-io metadata request with https://phet.colorado.edu/services/metadata/phetio?&active=true&latest=true","level":"info"}
{"message":"git checkout 1.2 on balancing-act","level":"info"}
{"message":"getting dependencies.json for balancing-act","level":"info"}
{"message":"git checkout master on balancing-act","level":"info"}
{"message":"git check (in chipper) for whether 8db0653ee0cbb6ed716fa3b4d4759bcb75d8118a is an ancestor of 2aa9c4c6b8e8f29bc50288065706c34ec65c3980","level":"info"}
{"message":"git checkout 1.3-phetio on balloons-and-static-electricity","level":"info"}
{"message":"getting dependencies.json for balloons-and-static-electricity","level":"info"}
{"message":"git checkout master on balloons-and-static-electricity","level":"info"}
I don't know how winston is used in the build-server, but log.js would need to be brought up to a new API. I think also that we would want to use the upgrade guide https://github.com/winstonjs/winston/blob/HEAD/UPGRADE-3.0.md.
This is more work the getting rid of find-duplicates over in https://github.com/phetsims/chipper/issues/993, but it may not be too bad, and feels like we should upgrade since we are currently on a version before 1.0.
Over to @ariel-phet to see about getting rid of this warning in perennial.
ariel-phet
jbphet
samreid
liammulh
mattpen
This is causing https://github.com/phetsims/chipper/issues/993 when loading perennials' gruntfile.
I applied this patch, but it didn't work right out of the bag, likely because winston's api has changed:
I'm not sure what the priority of this issue should be, or who is responsible for winston in this repo. I don't know why our gruntfile uses winston, since it was meant to be logging for the build-server.