search

phetsims / perennial

Maintenance tools that won't change with different versions of chipper checked out
MIT License
3 stars 5 forks source link

Change wording of prompt in production.js #230

Closed pixelzoom closed 3 years ago

pixelzoom commented 3 years ago

Running grunt production (production.js) prompts the user with:

Are there no untested maintenance patches that need spot checks? (An issue would be created in the sim repo) [y/N]?

Every time I see this, I have to read it at least twice. It's a double negative. How about changing this prompt to the following?

Have all maintenance patches that need spot checks been tested? (An issue would be created in the sim repo) [y/N]?

I would have changed this myself, by because it's in perennial, I wasn't sure if changing would mess something up.

jonathanolson commented 3 years ago

Changed above, thanks. Closing.