phetsims / perennial

Maintenance tools that won't change with different versions of chipper checked out
MIT License
2 stars 5 forks source link

Missing translation builds #258

Closed oliver-phet closed 2 years ago

oliver-phet commented 2 years ago

Reported by Sandor and Yoan (longtime translators).

ON: Hey John and Liam, Sandor just reported some Hungarian (hu) translations are showing up on the website. Collision Lab and Ratio and Proportion. The translations were both submitted yesterday and the string files appear to have been updated in babel. Is there something going on with the build process because the translated sims aren’t showing up on the site: https://phet.colorado.edu/en/simulations/filter?locale=hu&sort=newest&view=list

Liam Mulhall: Hmm… Nothing has changed in the Rosetta repository for quite some time, so if there's a new issue, I'm guessing it has to do with the build server.

John Blanco: It definitely looks like a build server problem. There are no "Build Succeeded" messages in the build server's log since a CCK AC build request that occurred at 16:52:29 yesterday. I can see Sandor's build requests coming in for the sims Oliver listed, and they are getting queued, but the build doesn't appear to finish. There are no obvious errors in the log other than some messages about problems adding translation credits to the DB. Oliver - I'd recommend creating an issue in perennial, putting this information in it, and then assigning it to Matt and pinging him. If he needs it, we do now have the means to re-request a translation build. My best guess at this point would be that the build server is "stuck" with some unresolved Promise or something along that line.

@mattpen assigning to you to investigate!

jbphet commented 2 years ago

Actually, I think I made a mistake when looking through the build server log - I was searching on the "Build Successful" string, which is only present when an email is sent. I should have been looking for "finished successfully", which does appear in the log. So, I think the builds may be fine, which means it may be more of a deployment problem.

Also, so that it doesn't go unnoticed, there are several instance of there message: error: error occurred when attempting to add translator credit info to DB: Error: Request failed with status code 400

liammulh commented 2 years ago

There are also errors associated with sending emails.

EDIT: Actually, I think these are old errors.

liammulh commented 2 years ago

If it helps, here's a build error from the 14th (two days ago as of this writing):

Dec 14 14:10:43 phet-server.int.colorado.edu build-server[30296]: error: Build failure: Error: Build aborted, TimeoutError: waiting for function failed: timeout 30000ms exceeded. Sim = circuit-construction-kit-ac Version = 1.0.0 Brands = phet Locales = * Shas = {"comment":"# circuit-construction-kit-ac 1.0.0 Tue Dec 14 2021 14:07:11 GMT-0700 (Mountain Standard Time)","assert":{"sha":"767b2f345518ceca5144a152ecf40cd4f9206136","branch":"HEAD"},"axon":{"sha":"bcb2817f963ab22685fbb5bde7017008d92178ea","branch":"HEAD"},"bamboo":{"sha":"1f76417e363625a97a5b2c6c90b3d54b857a096f","branch":"HEAD"},"brand":{"sha":"2552e723a049d380528eeb03184dd3cdd402121e","branch":"HEAD"},"chipper":{"sha":"a777699ffdf0554147a19b45390415eac0d3ff38","branch":"HEAD"},"circuit-construction-kit-ac":{"sha":"d3e96b164770cab52e9207602041d2604c13d673","branch":"1.0"},"circuit-construction-kit-common":{"sha":"2174f6a80cf3776d1803778b1c529b28b7fb3afd","branch":"HEAD"},"dot":{"sha":"67d17a901ca09970b8a74bcb611e48ba56404342","branch":"HEAD"},"joist":{"sha":"8eaa6445e7458f64965b86674db2f810f35720a5","branch":"HEAD"},"kite":{"sha":"6502ea6834ae0d77c0320973e25ad9726914f6ba","branch":"HEAD"},"perennial-alias":{"sha":"0998891a5aa7c4dd05639c2be7bd747356d56843","branch":"HEAD"},"phet-core":{"sha":"f23fac30eb0279af8f10e786408f22586c9de393","branch":"HEAD"},"phet-io":{"sha":"8748286bf16d55266183b592f7ab3a41801ff616","branch":"HEAD"},"phet-io-client-guides":{"sha":"e400520eff875c8d858af87667fad5b0daba4a72","branch":"HEAD"},"phet-io-wrappers":{"sha":"bc457edbc7b5a6d2a5452a2ec8f80bf83eccfd66","branch":"HEAD"},"phetcommon":{"sha":"0dd5378b39009e61ec33e7285e6744b681adc8d4","branch":"HEAD"},"phetmarks":{"sha":"64b01a476a9b51471d8080dc8962df6cc0ed5e29","branch":"HEAD"},"query-string-machine":{"sha":"b34079414b982587bd382a81a254e9f362e8772c","branch":"HEAD"},"scenery":{"sha":"ad3f44aecf29ba44102c26da8a82d30a51c5e8df","branch":"HEAD"},"scenery-phet":{"sha":"c91e731a2ff812e2721feeda86307ca09216f67d","branch":"HEAD"},"sherpa":{"sha":"1c42b328fd99c71c71d77aa820376df5f2b34ed0","branch":"HEAD"},"studio":{"sha":"5a0e9fb77f4cd7f83284a0b33e162896a1480f89","branch":"HEAD"},"sun":{"sha":"e7bf7bea865a781b7a8bff476b694aee8d1f25ad","branch":"HEAD"},"tambo":{"sha":"bbd659d9f4303f963010fececf11601931218461","branch":"HEAD"},"tandem":{"sha":"1ef31ff591f61a0c040638e55240e36b14cd784c","branch":"HEAD"},"twixt":{"sha":"bcdd52a5630885b865ddd99bc6927e5203b03897","branch":"HEAD"},"utterance-queue":{"sha":"09d1fe76bba4b2e7bd329c82ebfe579fbf96a7a3","branch":"HEAD"}}
Dec 14 13:46:41 phet-server.int.colorado.edu build-server[30296]: Fatal error: Perennial task failed:
Dec 14 13:46:41 phet-server.int.colorado.edu build-server[30296]: Error: Cannot find module 'acorn'
mattpen commented 2 years ago

I'd say there is a good chance this was related to https://github.com/phetsims/website/issues/1299. Is this problem still occurring? I think the new route for rebuilding translations would be the best way to notify the website database about the missing translations. @oliver-phet - is there a list of sims that are missing?

oliver-phet commented 2 years ago

It's not clear to me if this is still occurring. I'll ping Sandor to see if he can submit a sim to test.

oliver-phet commented 2 years ago

@mattpen I just got another report of a missing translation for CCKAC:Virtual Lab in Arabic _ar. It looks like the sim file was created this morning at 2022-03-30 03:50: https://phet.colorado.edu/sims/html/circuit-construction-kit-ac-virtual-lab/1.0.1/

Are translations taking longer to become visible on the website? We specify "Within half an hour" in the translation user guide.

mattpen commented 2 years ago

Are translations taking longer to become visible on the website? We specify "Within half an hour" in the translation user guide.

Yes, we should probably change that to 48 hours. I verified that the translation credit (rania.saleh@alefeducation.com) exists in the database.

mattpen commented 2 years ago

@oliver-phet - is this issue ok to close?